Today a friend of mine asked me to explain (via email) a few things to another developer regarding some things I have done with the Entity Framework (EF). I figured since I already typed it up I might as well share it here as well. So here it is.
I have had 2 issues with using EF4 which I have found creative and effective work around for.
Externalizing filters
The first issue, which also exists when using other frameworks, is that you end up with an explosion of methods (and usually a lot of duplicated code). For instance let’s say you have a table to store users. This table has an ID, and Email field and, and let’s and OpenIdUrl. So you end up with the following methods.
1 | User GetUserById(long id) |
3 | User GetUserByEmail(string email) |
5 | User GetUserByOpenIdUrl(string openIdUrl) |
Usually you’ll find that each of these methods have the exact same implementation except a different where clause. Now there is a bigger problem in the fact that you cannot anticipate everything that the user may want to filter on. Because of this and the dynamic nature of IQueryable I have employed a technique using Expression Trees to allow the user to declare the exact filter to be used via a lambda expression. So for the users it’s very slick. For example I could create the following method
01 | public User GetUser(Expression<func<user, bool="">> filter) |
05 | filter = Const<user>.LinqExpression.LinqExpressionFuncAlwaysTrue; |
08 | User foundUser = null; |
09 | using (InlineTasksContext dbContext = new InlineTasksContext()) |
11 | dbContext.Connection.Open(); |
12 | foundUser = dbContext.Users.Where(filter).SingleIfExists(); |
In this case I’m allowing the user to pass in a filter that is applied to the query. Here is how I could implement those three if I chose to as well.
01 | public User GetUserById(long id) |
03 | return this.GetUser(user => user.Id == id); |
05 | public User GetUserByEmail(string email) |
07 | if (email == null) { throw new System.ArgumentNullException("email"); } |
09 | return GetUser(user => user.Email == email); |
11 | public User GetUserByOpenIdUrl(string openIdUrl) |
13 | if (string.IsNullOrEmpty(openIdUrl)) { throw new ArgumentNullException("openIdUrl"); } |
15 | return GetUser(user => user.OpenIdUrl == openIdUrl); |
Note in the first method I am using some other helpers I created. Specifically the Const.LinqExpression.LinqExpressionFuncAlwaysTrue as well as the SingleIfExists
extension method. I use the AlwaysTrue expression so that way I don’t have to be worried about doing an if and having to maintain 2 select statements. And the other (SingleIfExists) is used to just return null instead of blowing up if no elements exist in the sequence.
Since they are not the purpose of this email I’ve just put them at the bottom so that you can read if you are interested.
As Keith mentioned to me a while back Expression trees are not serializable so you still end up with this problem if you are using a service based solution. But you could try and use the sample Expression Tree Serialization to take care of this for you, I’ve never tried it, but it’s on my TODO list.
.Include
My next issue is that you are forced to declare what navigation properties (i.e. table links) should be included in the query. This is done using the .Include method. So back to our GetUser example, how can a framework know what tables values should be extracted for? The end result is that the framework creator just includes a bunch of tables and 90% of the time the result is just wasted resources because the other data is never touched. Better is to provide a default which only includes the most commonly used tables and another method that allows them to specify what they want. Here is a sample for a GetTasksByUserId method
01 | public IList<task> GetTasksByUserId(long userId, IEnumerable<string> includeList) |
03 | using (InlineTasksContext dbContext = new InlineTasksContext()) |
05 | var result = (from t in dbContext.Tasks |
07 | .Where(t=>t.User.Id == 1) |
13 | In this example I’m using an extension method for.Include which is defined as follows. |
14 | public static ObjectQuery<t> Include<t>(this ObjectQuery<t> query, IEnumerable<string> includes) |
16 | if (query == null) { throw new System.ArgumentNullException("query"); } |
20 | foreach (string include in includes) |
22 | query.Include(include); |
26 | }</string></t></t></t></string></task> |
So the idea is to create a framework which is both robust and easy to use, but at the same time is not overly assumptive about what the users want. I think a lot more can be done with EF and its dynamic nature.
Does that cover what you were intending Keith? Any questions/comments please send them my way.
Here are those methods I mentioned above.
01 | public static class LinqExtensions |
03 | public static T SingleIfExists<t>(this IQueryable<t> query) |
05 | if (query == null) { throw new System.ArgumentNullException("query"); } |
07 | T result = default(T); |
08 | if (query.Count() > 0) |
10 | result = query.Single(); |
19 | public static class Predicate |
21 | public static Predicate<t> AlwaysTrue |
29 | public static Predicate<t> AlwaysFalse |
38 | public class LinqExpression |
40 | public static Expression<func<t, bool="">> LinqExpressionFuncAlwaysTrue |
48 | }</func<t,></t></t></t></t></t> |
Sayed Ibrahim Hashimi
Comments are closed.